Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Multiprecision refactoring: inverse mod and big_int improvements, checked big_uint operations #214

Open
wants to merge 29 commits into
base: master
Choose a base branch
from
Open

Multiprecision refactoring: inverse mod and big_int improvements, checked big_uint operations #214

wants to merge 29 commits into from
+24,147 −23,957

Conversation

ioxid
Copy link
Contributor

@ioxid ioxid commented Dec 18, 2024 •
edited
Loading

Also general cleanup, more tests and fixes.

@ioxid ioxid force-pushed the multiprecision-refactoring-step-3 branch 2 times, most recently from dd5d873 to 4ab0dc5 Compare December 18, 2024 16:34
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 18, 2024 •
edited
Loading

Clang Test Results

  158 files   -  3    158 suites   - 3   12m 54s ⏱️ - 3m 47s
7 165 tests +79  7 154 ✅ +74  6 💤 ±0  0 ❌ ±0  5 🔥 +5 
7 239 runs  +67  7 228 ✅ +62  6 💤 ±0  0 ❌ ±0  5 🔥 +5 

For more details on these errors, see this check.

Results for commit 1b01b72. ± Comparison against base commit 9b3fb27.

This pull request removes 115 and adds 194 tests. Note that renamed tests count towards both. 
addition ‑ wraps
addition ‑ wraps_rev
lpc_math_polynomial_suite ‑ lpc_basic_skipping_layers_test
lpc_math_polynomial_suite ‑ lpc_dfs_basic_test
lpc_params_test_suite ‑ lpc_batches_num_3_test
lpc_params_test_suite ‑ lpc_different_hash_types_test
multiplication ‑ wraps
pack_equal_test_suite ‑ bubb_to_bubb_1
pack_equal_test_suite ‑ bubb_to_bubb_2
pack_equal_test_suite ‑ bubb_to_bubb_3
…

add_assign_with_carry_test
addition ‑ overflow_throws
addition ‑ overflow_throws_rev
assignment ‑ assignment_signed<int>
assignment ‑ assignment_signed<long>
assignment ‑ assignment_signed<short>
assignment ‑ assignment_signed<signed_char>
assignment ‑ assignment_unsigned<unsigned_char>
assignment ‑ assignment_unsigned<unsigned_int>
assignment ‑ assignment_unsigned<unsigned_long>
…

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 18, 2024 •
edited
Loading

Gcc Test Results

  158 files   -   3    158 suites   - 3   14m 3s ⏱️ - 2m 57s
7 262 tests +176  7 251 ✅ +171  6 💤 ±0  0 ❌ ±0  5 🔥 +5 
7 336 runs  +164  7 325 ✅ +159  6 💤 ±0  0 ❌ ±0  5 🔥 +5 

For more details on these errors, see this check.

Results for commit 1b01b72. ± Comparison against base commit 9b3fb27.

This pull request removes 12 and adds 188 tests. Note that renamed tests count towards both. 
addition ‑ wraps
addition ‑ wraps_rev
multiplication ‑ wraps
runtime_tests ‑ bad_negation
runtime_tests ‑ conversion_to_shorter_number
runtime_tests ‑ secp256k1_incorrect_multiplication
runtime_tests ‑ test_cpp_int_modular_backend_6_bits
static_tests ‑ base_ops_even_mod_backend_130
static_tests ‑ base_ops_even_mod_backend_17
static_tests ‑ base_ops_even_mod_backend_64
…

add_assign_with_carry_test
addition ‑ overflow_throws
addition ‑ overflow_throws_rev
assignment ‑ assignment_signed<int>
assignment ‑ assignment_signed<long>
assignment ‑ assignment_signed<short>
assignment ‑ assignment_signed<signed_char>
assignment ‑ assignment_unsigned<unsigned_char>
assignment ‑ assignment_unsigned<unsigned_int>
assignment ‑ assignment_unsigned<unsigned_long>
…

♻️ This comment has been updated with latest results.

@ioxid ioxid force-pushed the multiprecision-refactoring-step-3 branch from bf778b1 to 7bf24cf Compare December 19, 2024 01:41
ioxid added 23 commits December 19, 2024 10:22
@ioxid
multiprecision: big_uint: clean up wnaf
557af00
@ioxid
marshalling::multiprecision: remove boost includes
7c7e82a
@ioxid
marshalling::multiprecision: clean up tests
4f197c6
@ioxid
multiprecision: big_uint: rename limbs_count
fe86a97
@ioxid
multiprecision: big_uint: remove carry field, make operators checked …
a1e31c5 
…and add wrapping operators
@ioxid
multiprecision: make benchmarks optimize correctly
4aa79bb
@ioxid
multiprecision: big_uint: optimize comparison
c0e35fb
@ioxid
multiprecision: add inverse benchmarks
aac7947
@ioxid
multiprecision: refactor big_int and inverse_extended_euclidean_algor…
b8ef425 
…ithm
@ioxid
multiprecision: throw on overflowing import
f86790e
@ioxid
multiprecision: move import and export to class definition
934a333
@ioxid
multiprecision: simplify intrinsics logic
eca8b41
@ioxid
multiprecision: remove detail/type_traits and clean up
9b220cf
@ioxid
multiprecision: replace custom asserts with boost
c4fc2bb
@ioxid
multiprecision: clean up formatting
29f2fd2
@ioxid
multiprecision: move more function inside classes
9f3eefb
@ioxid
multiprecision: make internal methods private
5d4901b
@ioxid
multiprecision: disable exception in import which fires in tests
62809e2
@ioxid
multiprecision: move boost backend tests into a subdirectory
d5122c3
@ioxid
multiprecision: rename tests
7affc91
@ioxid
multiprecision: remove examples
32714e1
@ioxid
multiprecision: add tests and fix bugs
09d0221
@ioxid
multiprecision: update and fix copyrights
81f11dd
@ioxid ioxid force-pushed the multiprecision-refactoring-step-3 branch from 7bf24cf to b8adb34 Compare December 19, 2024 14:45
@ioxid ioxid marked this pull request as ready for review December 19, 2024 15:56
@ioxid ioxid requested a review from martun December 19, 2024 15:56
@ioxid ioxid force-pushed the multiprecision-refactoring-step-3 branch from 6e9889f to 28f71fd Compare December 20, 2024 02:03
@ioxid ioxid force-pushed the multiprecision-refactoring-step-3 branch from 28f71fd to bf48eac Compare December 20, 2024 02:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martun martun Awaiting requested review from martun

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
multiprecision
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ioxid